Make sure there is a single manifest store in the asset #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #114 +/- ##
==========================================
- Coverage 77.10% 76.27% -0.84%
==========================================
Files 66 66
Lines 14131 14325 +194
==========================================
+ Hits 10896 10926 +30
- Misses 3235 3399 +164
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
gpeacock
reviewed
Aug 23, 2022
gpeacock
approved these changes
Aug 23, 2022
mauricefisher64
added a commit
that referenced
this pull request
Sep 30, 2022
…ff_support * 'main' of https://github.com/contentauth/c2pa-rs: (78 commits) Add Exif Assertion support (#140) (IGNORE) Disregard grep non-zero exit status (#139) Prepare 0.14.0 release (IGNORE) Fix GH Actions logic error that is causing CI failure now (#137) (MINOR) Remove previously embedded manifests for remote manifests (#136) (MINOR) Add support for manifest removal (#123) Prepare 0.13.2 release manifest_data was missing for remote manifests (#135) (IGNORE) Restore cargo-semver-checks step (#129) Prepare 0.13.1 release Add ManifestStore::from_manifest_and_asset_bytes_async (#130) (IGNORE) Disable cargo-semver-checks step (#126) (IGNORE) Enforce semantic versioning requirements during PR validation and publish workflows (#124) Prepare 0.13.0 release Add RemoteManifestUrl Error, returning url (#120) Convert status_log error val to a string so that we can return full errors (#121) Report failures from remote manifest fetch (#116) Fast XMP extraction from PNG (#117) Bump MSRV to 1.59.0 (#118) Make sure there is a single manifest store in the asset (#114) ... # Conflicts: # sdk/src/error.rs # sdk/src/jumbf_io.rs
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Make sure there is only one manifest store in the asset when we read it.
Fix buffer read error on bad data.
Checklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.