Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

(MINOR) Detailed API review for Ingredient struct #17

Merged
merged 9 commits into from
May 26, 2022

Conversation

gpeacock
Copy link
Collaborator

@gpeacock gpeacock commented May 25, 2022

Changes in This Pull Request

  • Adds missing setters and uses Into<String> parameters
  • Updates documentaton
  • Adds more unit test coverage

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

@codecov-commenter
Copy link

codecov-commenter commented May 25, 2022

Codecov Report

Merging #17 (1193f4c) into main (f3d5f86) will increase coverage by 0.20%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #17      +/-   ##
==========================================
+ Coverage   73.69%   73.90%   +0.20%     
==========================================
  Files          61       61              
  Lines       12064    12113      +49     
==========================================
+ Hits         8891     8952      +61     
+ Misses       3173     3161      -12     
Impacted Files Coverage Δ
sdk/src/ingredient.rs 90.55% <100.00%> (+4.71%) ⬆️
sdk/src/manifest.rs 86.44% <100.00%> (ø)
sdk/src/openssl/ec_signer.rs 90.78% <0.00%> (-1.32%) ⬇️
sdk/src/jumbf/boxes.rs 71.63% <0.00%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3d5f86...1193f4c. Read the comment docs.

@scouten-adobe scouten-adobe changed the title Adds missing setters and uses Into<String> parameters (MINOR) Adds missing setters and uses Into<String> parameters May 25, 2022
add periods to doc comments
@gpeacock gpeacock requested a review from scouten-adobe May 26, 2022 17:08
@scouten-adobe scouten-adobe changed the title (MINOR) Adds missing setters and uses Into<String> parameters (MINOR) Detailed API review for Ingredient struct May 26, 2022
scouten-adobe
scouten-adobe previously approved these changes May 26, 2022
@gpeacock gpeacock merged commit e1c2f1a into main May 26, 2022
@gpeacock gpeacock deleted the gpeacock/ingredient_setters branch May 26, 2022 20:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants