(MINOR) Create a ResourceStore for binary assets #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with_files and without
Can read and write files thumbs and manifests
reading and writing thumbnail images is now only done via ResourceStore
gpeacock
requested review from
dkozma,
scouten-adobe,
mauricefisher64,
dyro and
emensch
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #180 +/- ##
==========================================
+ Coverage 77.61% 78.04% +0.43%
==========================================
Files 68 69 +1
Lines 16207 16689 +482
==========================================
+ Hits 12579 13025 +446
- Misses 3628 3664 +36
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
thumbnail back to tuple options manifest_data now uses resource_ref Added exists to ResourceStore
add default claim_generator add parent function on manifest
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Create a ResourceStore for binary assets in Manifest and Ingredient
Converts Thumbnail fields to ResourceRef values
Direct support for serialize/ deserialize Manifest and Ingredient with JSON
Optionally read/write thumbnail and manifest files to folder for embed and
add Ingredient::from_file_with_resources and ManifestStore::from_file_with_resources
Deserialize ManifestStore to JSON and write all files to folder
Checklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.