Add write support for HEIC, HEIF, AVIF #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # sdk/src/utils/hash_utils.rs
BMFF generation bug for remote manifests
# Conflicts: # sdk/src/asset_handlers/bmff_io.rs # sdk/src/store.rs
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #210 +/- ##
==========================================
+ Coverage 78.80% 78.91% +0.10%
==========================================
Files 70 70
Lines 17625 17843 +218
==========================================
+ Hits 13890 14080 +190
- Misses 3735 3763 +28
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
scouten-adobe
approved these changes
Mar 13, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
This PR adds support to patch offsets for formast that use /meta/iloc to reference data. Specifically we have enabled support for HEIC, HEIF, AVIF
Checklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.