Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

(MINOR) Added ResourceNotFound error #244

Merged
merged 4 commits into from
May 3, 2023
Merged

Conversation

gpeacock
Copy link
Collaborator

@gpeacock gpeacock commented May 3, 2023

returned if thumbnails or c2pa manifests are missing
reports the identifier or path of missing resource
_

returned if thumbnails or c2pa manifests are missing
reports the identifier or path of missing resource
@gpeacock gpeacock requested a review from dyro May 3, 2023 05:51
@codecov-commenter
Copy link

codecov-commenter commented May 3, 2023

Codecov Report

Merging #244 (e519ebb) into main (2f6f8bd) will increase coverage by 0.01%.
The diff coverage is 87.87%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #244      +/-   ##
==========================================
+ Coverage   79.40%   79.42%   +0.01%     
==========================================
  Files          71       71              
  Lines       18993    19010      +17     
==========================================
+ Hits        15082    15099      +17     
  Misses       3911     3911              
Impacted Files Coverage Δ
sdk/src/error.rs 25.00% <ø> (ø)
sdk/src/resource_store.rs 94.07% <40.00%> (-1.23%) ⬇️
sdk/src/manifest.rs 89.96% <95.00%> (+0.01%) ⬆️
sdk/src/ingredient.rs 86.24% <100.00%> (+0.03%) ⬆️

... and 1 file with indirect coverage changes

@gpeacock gpeacock changed the title Added ResourceNotFound error (MINOR) Added ResourceNotFound error May 3, 2023
ensure folders are created on embed
@gpeacock gpeacock closed this May 3, 2023
@gpeacock gpeacock reopened this May 3, 2023
@gpeacock gpeacock merged commit d75eca3 into main May 3, 2023
@gpeacock gpeacock deleted the gpeacock/resource_not_found branch May 3, 2023 19:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants