adds ManifestStoreReport::cert_chain_from_bytes #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #286 +/- ##
==========================================
+ Coverage 78.41% 78.42% +0.01%
==========================================
Files 76 76
Lines 22153 22169 +16
==========================================
+ Hits 17371 17387 +16
Misses 4782 4782
|
dyro
force-pushed
the
dyross/cert_chain_from_bytes
branch
from
476b54f to
4c83c14
Compare
dyro
force-pushed
the
dyross/cert_chain_from_bytes
branch
from
4c83c14 to
9b852aa
Compare
gpeacock
reviewed
Jul 28, 2023
| let bytes = fs::read(fixture_path("no_manifest.jpg")).expect("missing test asset"); | ||
| assert!(matches!( | ||
| ManifestStoreReport::cert_chain_from_bytes("jpg", &bytes), | ||
| Err(crate::Error::JumbfNotFound) |
There was a problem hiding this comment.
nice having the negative case!
gpeacock
approved these changes
Jul 28, 2023
|
All tests passed, but the mysterious Rust 1.65 unit tests never finished. Merging anyway! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
This adds a convenience method for retrieving the certificate chain used to sign the active manifest from the bytes of the file containing the manifest.
Checklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.