Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix for overly harsh checks when checking Merkle trees. #289

Merged
merged 4 commits into from
Aug 10, 2023

Conversation

mauricefisher64
Copy link
Collaborator

Changes in this pull request

Fix issue found during interop testing where our safety checks were too strict.

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2023

Codecov Report

Merging #289 (442f773) into main (0375b6f) will increase coverage by 0.06%.
The diff coverage is 68.42%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #289      +/-   ##
==========================================
+ Coverage   78.44%   78.51%   +0.06%     
==========================================
  Files          76       76              
  Lines       22198    22181      -17     
==========================================
+ Hits        17414    17415       +1     
+ Misses       4784     4766      -18     
Files Changed Coverage Δ
sdk/src/assertions/bmff_hash.rs 20.62% <0.00%> (+0.77%) ⬆️
sdk/src/jumbf/boxes.rs 71.61% <72.22%> (-0.07%) ⬇️

@mauricefisher64 mauricefisher64 merged commit 1c6cd7f into main Aug 10, 2023
@mauricefisher64 mauricefisher64 deleted the bmff_fixes branch August 10, 2023 20:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants