Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add ManifestStore::from_stream #319

Merged
merged 14 commits into from
Oct 13, 2023
Merged

Add ManifestStore::from_stream #319

merged 14 commits into from
Oct 13, 2023

Conversation

gpeacock
Copy link
Collaborator

@gpeacock gpeacock commented Oct 4, 2023

Adds ManifestStore.from_stream() so you can create a manifest store from a stream.

with output stream and returning c2pa_data
replaces embed_stream
Fixes a bug in embed_stream where missing thumbnails were not reported
@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (2d440a2) 78.94% compared to head (a2afc77) 78.97%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #319      +/-   ##
==========================================
+ Coverage   78.94%   78.97%   +0.02%     
==========================================
  Files          79       79              
  Lines       23556    23589      +33     
==========================================
+ Hits        18597    18629      +32     
- Misses       4959     4960       +1     
Files Coverage Δ
sdk/src/manifest.rs 91.83% <ø> (ø)
sdk/src/manifest_store.rs 85.34% <97.05%> (+1.40%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@scouten-adobe scouten-adobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few proofreading/documentation edits and one question, not a blocker.

@gpeacock gpeacock changed the title Streaming API additions and fixes Add ManifestStore::from_stream Oct 13, 2023
@gpeacock gpeacock merged commit d9b077c into main Oct 13, 2023
@gpeacock gpeacock deleted the gpeacock/api_tweaks branch October 13, 2023 02:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants