-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Remove need for using OpenSSL to generate certs by using pre-generated certs #41
Conversation
Codecov Report
@@ Coverage Diff @@
## main #41 +/- ##
==========================================
- Coverage 72.66% 71.57% -1.10%
==========================================
Files 62 62
Lines 12547 12604 +57
==========================================
- Hits 9117 9021 -96
- Misses 3430 3583 +153
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of suggestions included
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stand by … I'm reviewing this PR, too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple minor tweaks; otherwise 👍.
* 'main' of https://github.com/contentauth/c2pa-rs: Apply fix from c2patool publish workflow (#40) Remove need for using OpenSSL to generate certs by using pre-generated certs (#41)
Changes in this pull request
User can use the c2pa_rs without the need generate certs via opensll
Checklist
TO DO
items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.