Adds Action changes field as option vec of serde_json value #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are no Rust APIS for this yet. But it allows the values to pass through via actions.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #431 +/- ##
==========================================
+ Coverage 79.81% 79.86% +0.05%
==========================================
Files 82 82
Lines 25401 25494 +93
==========================================
+ Hits 20275 20362 +87
- Misses 5126 5132 +6 ☔ View full report in Codecov by Sentry. |
dkozma
approved these changes
Mar 25, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are no Rust APIS for this yet.
But it allows the values to pass through via actions.
This is a minimal change to allow the new actions. changes field to be set via JSON and read back that way.
Adding detailed Rust APIs should wait until the spec for this is completed