Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Streaming XMP write support for PNG #439

Merged
merged 11 commits into from
Apr 4, 2024
Merged

Streaming XMP write support for PNG #439

merged 11 commits into from
Apr 4, 2024

Conversation

mauricefisher64
Copy link
Collaborator

Changes in this pull request

PNG files streaming is now fully supported by PR

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 83.47107% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 80.31%. Comparing base (ad4c015) to head (d5be821).

Files Patch % Lines
sdk/src/asset_handlers/png_io.rs 83.47% 20 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #439      +/-   ##
==========================================
+ Coverage   80.28%   80.31%   +0.03%     
==========================================
  Files          82       82              
  Lines       25758    25867     +109     
==========================================
+ Hits        20680    20776      +96     
- Misses       5078     5091      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dkozma
Copy link
Contributor

dkozma commented Apr 2, 2024

As part of the png_pong fix, the MSRV for that crate was updated to 1.77 😞 - looking to see if the author can revise that to an earlier version, since the fix shouldn't necessitate an increase in the Rust version.

@dkozma
Copy link
Contributor

dkozma commented Apr 2, 2024

I've contacted the author of the png_pong crate regarding the MSRV version in AldaronLau/png_pong#22 and will update this ticket with any new information.

@dkozma dkozma merged commit c5282c1 into main Apr 4, 2024
22 checks passed
@dkozma dkozma deleted the png_xmp branch April 4, 2024 18:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants