Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Gpeacock/embed_remote_settings #460

Merged
merged 7 commits into from
May 1, 2024
Merged

Conversation

gpeacock
Copy link
Collaborator

Adds a way to set the remote_url and no_embed option for Builder.
Enables BMFF format for streams.
Adds io and streaming tests.

Copy link
Contributor

@dyro dyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Couple of quick questions / suggestions

@gpeacock gpeacock merged commit ec8095b into main May 1, 2024
22 checks passed
@gpeacock gpeacock deleted the gpeacock/embed_remote_settings branch May 1, 2024 21:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants