Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Expose SignatureInfo publicly #501

Merged
merged 4 commits into from
Jul 16, 2024
Merged

Expose SignatureInfo publicly #501

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dc33c00
Expose `SignatureInfo` publicly
ok-nick Jul 10, 2024
aaf51e4
Make `SignatureInfo` ser/de fields public
ok-nick Jul 10, 2024
8ac5e04
Merge branch 'main' into ok-nick/pub-signature-info
gpeacock Jul 16, 2024
dea132a
Merge branch 'main' into ok-nick/pub-signature-info
gpeacock Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ pub use hash_utils::{hash_stream_by_alg, HashRange};
pub use ingredient::Ingredient;
#[cfg(feature = "file_io")]
pub use ingredient::{DefaultOptions, IngredientOptions};
pub use manifest::Manifest;
pub use manifest::{Manifest, SignatureInfo};
pub use manifest_assertion::{ManifestAssertion, ManifestAssertionKind};
#[cfg(feature = "v1_api")]
pub use manifest_store::ManifestStore;
Expand Down
16 changes: 8 additions & 8 deletions sdk/src/manifest.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1402,26 +1402,26 @@ impl std::fmt::Display for Manifest {
pub struct SignatureInfo {
/// human readable issuing authority for this signature
#[serde(skip_serializing_if = "Option::is_none")]
alg: Option<SigningAlg>,
pub alg: Option<SigningAlg>,
/// human readable issuing authority for this signature
#[serde(skip_serializing_if = "Option::is_none")]
issuer: Option<String>,
pub issuer: Option<String>,

/// The serial number of the certificate
#[serde(skip_serializing_if = "Option::is_none")]
cert_serial_number: Option<String>,
pub cert_serial_number: Option<String>,

/// the time the signature was created
#[serde(skip_serializing_if = "Option::is_none")]
time: Option<String>,
pub time: Option<String>,

/// revocation status of the certificate
#[serde(skip_serializing_if = "Option::is_none")]
pub revocation_status: Option<bool>,

/// the cert chain for this claim
#[serde(skip)] // don't serialize this, let someone ask for it
cert_chain: String,

/// revocation status of the certificate
#[serde(skip_serializing_if = "Option::is_none")]
revocation_status: Option<bool>,
}

impl SignatureInfo {
Expand Down
Loading