(MINOR) IngredientOptions allow override of hash and thumbnail generation; image library is now a default feature
#79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add thumbnail option
Codecov Report
@@ Coverage Diff @@
## main #79 +/- ##
==========================================
- Coverage 74.50% 74.42% -0.09%
==========================================
Files 66 66
Lines 13471 13565 +94
==========================================
+ Hits 10037 10096 +59
- Misses 3434 3469 +35
Continue to review full report at Codecov.
|
|
This is required for allowing PS to not generate thumbnails via the cai-helper |
scouten-adobe
changed the title
scouten-adobe
requested changes
Jul 16, 2022
scouten-adobe
requested changes
Jul 19, 2022
scouten-adobe
changed the title
IngredientOptions allow override of hash and thumbnail generation; image library is now a default feature
scouten-adobe
approved these changes
Jul 19, 2022
mauricefisher64
added a commit
that referenced
this pull request
Jul 20, 2022
…timize * 'main' of https://github.com/contentauth/c2pa-rs: (MINOR) `IngredientOptions` allow override of hash and thumbnail generation; image library is now a default feature (#79) Prepare 0.9.1 release Fix publish workflow (#82) Prepare 0.9.0 release (MINOR) Introduce a new `SigningAlg` enum (#76) # Conflicts: # sdk/src/ingredient.rs
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
IngredientOptions is now a trait with three methods to override title, hash and thumbnail generation
The blake3 hash is no longer built in, if a hash is desired it can be added via ingredientOptions.
add_thumbnails feature now controls if the image crate is included in a build, by default it is enabled
updated to latest image library
added additional file type/mime mappings for ingredients
Checklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.