chore: bail rollup and lerna when TS errors [] #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dimitrycf
approved these changes
Jan 30, 2024
|
Actually once I cleared npm cache and rebuilt SDK again it showed this error:
We can quick fix it by allowing the
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, a TS error does not yield an error when building with rollup.
Using the config noEmitOnError, TS will now return an error that can be consumed by rollup and leads to a subsequent abortion of rollup and lerna.
Video: https://www.loom.com/share/97ba8ed8671f4d5187514b88332bfcd9
Related bug: rollup/rollup-plugin-typescript#43