Latte 3 support #106
Latte 3 support #106
Conversation
|
@MartinMystikJonas what you think about drop support for Latte < 3? |
|
@aleswita At this point it is not necessary so I would keep support for both. Latte 3 is not yet supported by all packages so many projects would keep Latte 2 for some time. We can drop support for Latte 2 later to clean up code (together with deprecated I... interfaces). |
|
@MartinMystikJonas ok. Last think, can you fix last error in phpstan? |
|
I will look at it. For some reason prefer lowest installed different versions of libs on my machine so this error did not showed up. But it could be simply ignored because it is caused by Nette interface rename that is BC compatible but PHPStan cannot interpret it. |
MartinMystikJonas
force-pushed
the
latte3
branch
from
c75a084 to
03e49bf
Compare
|
@aleswita Could you approve me to run workflows? I pushed new version with PHPStan fix but it did not re-run. |
MartinMystikJonas
force-pushed
the
latte3
branch
from
03e49bf to
aa1384c
Compare
|
Weird now I have same versions of libs on local and in CI (it required --ignore-platform-reqs) but it still behaves differently. NO sure why. I would need few iterations of trial-error to make it work in CI. |
|
Ha! Now it works! All checks passed in CI |
|
perfect, thank you |
Close #10 https://latte.nette.org/cs/creating-extension Helpful inspiration contributte/translation#106
Latte\TranslatorExtension){_}{/_}replaced with{translate}{/translate}(same as with Latte default translator)$ᴛ_(Because Latte 3 forbids prefix$ʟ_)