Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: drop resolve-from, resolve-global and import-fresh, resolve global packages correctly #3939

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

JounQin
Copy link
Contributor

@JounQin JounQin commented Feb 27, 2024

Description

fix #3938

Motivation and Context

Usage examples

// commitlint.config.js
module.exports = {};
echo "your commit message here" | commitlint # fails/passes

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@JounQin JounQin changed the title fix: drop resolve-from, resolve-global and import-fresh fix: drop resolve-from, resolve-global and import-fresh, resolve global packages correctly Feb 27, 2024
@JounQin
Copy link
Contributor Author

JounQin commented Feb 27, 2024

@escapedcat I'm not sure how to test this easily, but if we can enable something like Codesandbox CI or https://github.com/un-ts/preversion, we can release canary version for testing before releasing.

@escapedcat
Copy link
Member

Thanks, will merge and release!

we can enable something like Codesandbox CI or https://github.com/un-ts/preversion, we can release canary version for testing before releasing

Sure, wanna open an issue for that? Not sure how needed it really is but we can discuss in the issue.

@escapedcat escapedcat merged commit 8793c63 into conventional-changelog:master Feb 27, 2024
6 checks passed
@JounQin JounQin deleted the fix/global branch February 27, 2024 17:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Module not found
2 participants