Special handling for calendar_date#service_id reference not found in calendars.txt

[landonreed]

As part of the MTC enhancements added for supporting merging feeds, a foreign reference was added to the calendar_dates#service_id table. Doing so allows us to scope the service_id and possibly remap it if conflicts are encountered between two feeds.

gtfs-lib/src/main/java/com/conveyal/gtfs/loader/Table.java

Lines 138 to 142 in 5ec5285

	public static final Table CALENDAR_DATES = new Table("calendar_dates", CalendarDate.class, OPTIONAL,
	new StringField("service_id", REQUIRED).isReferenceTo(CALENDAR),
	new DateField("date", REQUIRED),
	new IntegerField("exception_type", REQUIRED, 1, 2)
	).keyFieldIsNotUnique();

However, this change will have the effect of causing false positives for referential integrity errors encountered during feed loading for GTFS feeds like TriMet's, which define service dates using calendar_dates (exception type = 1) alone. I have a fix inbound for this issue, which will only store the ref integrity error if the exception type is not 1.

[landonreed]

🎉 This issue has been resolved in version 4.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀