Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bug fix release #219

Merged
merged 3 commits into from
Apr 8, 2019
Merged

Bug fix release #219

merged 3 commits into from
Apr 8, 2019

Conversation

landonreed
Copy link
Contributor

@landonreed landonreed commented Apr 8, 2019

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing
  • The description lists all relevant PRs included in this release (remove this if not merging to master)
  • Code coverage does not significantly worsen (ideally it improves) (remove this if not merging to master)

Description

Incorporates bug fix related to missing parent_station field causing exceptions for GraphQL queries (#217).

@landonreed landonreed requested review from a team and evansiroky April 8, 2019 14:43
@codecov-io
Copy link

Codecov Report

Merging #219 into master will decrease coverage by 0.73%.
The diff coverage is 61.11%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #219      +/-   ##
============================================
- Coverage     60.77%   60.04%   -0.74%     
+ Complexity      904      902       -2     
============================================
  Files           145      145              
  Lines          7598     7426     -172     
  Branches        898      874      -24     
============================================
- Hits           4618     4459     -159     
+ Misses         2650     2643       -7     
+ Partials        330      324       -6
Impacted Files Coverage Δ Complexity Δ
...a/com/conveyal/gtfs/graphql/GraphQLGtfsSchema.java 98.27% <ø> (+0.32%) 1 <0> (ø) ⬇️
...om/conveyal/gtfs/graphql/fetchers/JDBCFetcher.java 65.1% <61.11%> (-4.74%) 31 <0> (-2)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19fe7fb...b3aa52e. Read the comment docs.

@evansiroky evansiroky assigned landonreed and unassigned evansiroky Apr 8, 2019
@landonreed landonreed merged commit dc4dd1e into master Apr 8, 2019
@landonreed
Copy link
Contributor Author

🎉 This PR is included in version 4.3.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants