-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Hot-reload support to celery #2554
Conversation
Nice addition! Is the pattern not to tight? Now the restarts do not happen when there are changes made to settings.py or models.py. So why not set it to *.py? |
@foarsitter I configured it that way on purpose, since I write all my tasks in those files. |
Nice addition indeed. Good question for the pattern, I'm not sure I understand the problem, but I probably just need to try it out 😄 |
Nice work! Consider using |
{{cookiecutter.project_slug}}/compose/local/django/celery/worker/start
Outdated
Show resolved
Hide resolved
{{cookiecutter.project_slug}}/compose/local/django/celery/worker/start
Outdated
Show resolved
Hide resolved
This is a great feature idea. Is there anything still needed before this can be merged (besides simply resolving the merge conflicts)? |
# Conflicts: # CONTRIBUTORS.rst
Yes, I kind of forgot about it, I think it's good to go. |
Thanks for your contribution @yotamtal 🎉 |
Description
This PR adds support for celery hot-reloading while developing, on changes to tasks.py and celery_app.py files when setting up a project with docker and celery.
Rationale
I have been using this Cookiecutter template for many projects and while developing with celery tasks I had to restart the worker manually to test the changes. This minor change will allow developers to test their celery tasks faster
Use case(s) / visualization(s)
-> Develop celery tasks -> notice a bug -> change the code -> save -> test the new code without restarting the worker manually