Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Adding GitHub-Action CI Option #2837

Merged
merged 14 commits into from
Sep 21, 2020

Conversation

arnav13081994
Copy link
Contributor

@arnav13081994 arnav13081994 commented Sep 17, 2020

Description

Adding an option to let users choose GitHub action as a CI tool.

Checklist:

  • I've made sure that tests/test_cookiecutter_generation.py is updated accordingly (especially if adding or updating a template option)
  • I've updated the documentation or confirm that my change doesn't require any updates

Rationale

Since this code repo is on Github it would make more sense to take advantage of the deep CI integration that GitHub now provides out of the box like dependency caching to speed up future builds.

@arnav13081994
Copy link
Contributor Author

@browniebroke I am having trouble understanding why the checks are failing. Looks like project_generation is exiting with code 1. I have updated the tests etc but don't understand why this is happening. Any help would be appreciated.

Copy link
Member

@browniebroke browniebroke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the issues might have to do with Jinja2 trying to interpolate GH actions variables (see below).

@browniebroke browniebroke merged commit b064e09 into cookiecutter:master Sep 21, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants