Fix docs service and add RTD support #2920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update master
* Set DATABASE_URL environment variable to sqlite inside conf.py instead of the compose file since it's not changed very often. * Setting the DATABASE_URL to SQLite avoids a dependency on the Postgres service * Docker docs service should use /start-docs to be consistent with other start commands * Added RTD configuration file
2 tasks
|
Sorry for the large number of commits. I must've messed up my git command or something. |
browniebroke
reviewed
Nov 4, 2020
Moving config inside of source fixed RTD, but broke the local setup. Move everything in docs source seems to be an easier fix
browniebroke
approved these changes
Nov 4, 2020
There was a problem hiding this comment.
I believe this is now ready to merge, thanks for the effort @Andrew-Chen-Wang
|
Thanks for the review! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2733
Closes #2878
Closes #2674
Supersedes #2754
Description
Fix docs service. Added
DATABASE_URLenvironment variable insideconf.pyto forcedjango.setup()in both local and production environments to use a SQLite database. Also stays consistent with setting the other entrypoint env var,CELERY_BROKER_URL.Checklist:
tests/test_cookiecutter_generation.pyis updated accordingly (especially if adding or updating a template option)Rationale
Fixes doc service and adds doc option for production.