Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Omit first_name and last_name in User model #2998

Merged
merged 3 commits into from
Jan 24, 2021

Conversation

Andrew-Chen-Wang
Copy link
Contributor

Description

Fixes #1268

Remove first_name and last_name from User model. This is just how I personally did it awhile ago.

Checklist:

  • I've made sure that tests/test_cookiecutter_generation.py is updated accordingly (especially if adding or updating a template option)
  • I've updated the documentation or confirm that my change doesn't require any updates

Rationale

We already have a name attribute, and the other attributes aren't used in any forms (as far as I can see in my current project).

@Andrew-Chen-Wang Andrew-Chen-Wang changed the title Omit first_name and last_name in User model [WIP] Omit first_name and last_name in User model Jan 8, 2021
@Andrew-Chen-Wang Andrew-Chen-Wang changed the title [WIP] Omit first_name and last_name in User model Omit first_name and last_name in User model Jan 8, 2021
@Andrew-Chen-Wang Andrew-Chen-Wang marked this pull request as ready for review January 8, 2021 03:39
@browniebroke browniebroke merged commit aee2559 into cookiecutter:master Jan 24, 2021
@browniebroke
Copy link
Member

Thanks again @Andrew-Chen-Wang !

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom user model still contains first_name and last_name
2 participants