Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add background jobs #353

Merged
merged 2 commits into from
May 18, 2018
Merged

Add background jobs #353

merged 2 commits into from
May 18, 2018

Conversation

enricostano
Copy link
Contributor

@enricostano enricostano commented May 10, 2018

WAT

We need a background jobs system in order to send emails, mobile push notifications, etc.

Dependencies

coopdevs/timeoverflow-provisioning#47 (Install Redis)

TODO BEFORE DEPLOY

  • provision redis on staging (Ansible scripts)
  • install redis by hand in production 😬

@markets
Copy link
Collaborator

markets commented May 12, 2018

Nice @enricostano! Taking into account that we'll have (and we'll depend on) redis, we can maybe drop the memcached dependency and use redis also as a cache store, in the future, so this will simplify our infrastructure.

@sauloperez
Copy link
Collaborator

that's a good idea @markets . I wonder though if we can completely get rid of the cache store to simplify the infrastructure as well as the code even further.

@markets
Copy link
Collaborator

markets commented May 12, 2018

Yes, right now we're using caching (=> and memcached) only for this #327 I think :(

@sauloperez
Copy link
Collaborator

sauloperez commented May 12, 2018

Yep, that's why we got it in our radar. 🔪 if possible.

@enricostano enricostano force-pushed the feature/background-jobs branch from ebdfbe7 to d8c72a4 Compare May 17, 2018 09:53
@enricostano enricostano self-assigned this May 17, 2018
@enricostano
Copy link
Contributor Author

we can maybe drop the memcached dependency and use redis also as a cache store, in the future, so this will simplify our infrastructure.

I whish we could, I remember a conversation with sys admins about redis not being the best option for cache... but I need to dig into that again. It was probably related to performance, I'll look into it.

@sauloperez
Copy link
Collaborator

Could be. But keep in mind that our use case is rather small. It might be one of those cases where the tradeoff of using it as a cache store makes sense.

@markets
Copy link
Collaborator

markets commented May 17, 2018

ok @enricostano not really sure (from a perfomance perspective) if redis can compete with memcached at scale. Probably no, since memcached was designed for this purpose. But as @sauloperez said, it's a question of trade-offs, and in our current situation: caching only is used to cache the devise reset passwords, resources are limited (infra, team)... maybe it wouldn't be a bad bad idea.

But to be honest, I'd try to revisit #327, think alternatives (remove, reimplement with DB), and probably just 🔥 the cache store for now, as Pau also pointed out:

🔪 if possible

@enricostano enricostano force-pushed the feature/background-jobs branch from d8c72a4 to 19a1c92 Compare May 18, 2018 07:52
@enricostano enricostano merged commit c57c6be into develop May 18, 2018
@enricostano enricostano deleted the feature/background-jobs branch May 18, 2018 07:57
@enricostano enricostano mentioned this pull request Aug 8, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants