-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
adapt reset password page to new styles #419
Conversation
d0cfee8
to
f0073d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find a bit odd, in terms of design, that cambiar mi contraseña
looks smaller than the inputs' placeholders. IMO it should be at least the same size as its the header.
I agree @sauloperez it could look much better 👌, I just followed the same markup as we currently use in the other <h2>Title</h2> The main difference with the rest (ie screenshot), is that in this case we don't have any sentence before the form. So, we can maybe make all panels |
You mean increasing h2's font size or making this whole white box bigger? |
@sauloperez as a first approach or at least for this PR, I'd go with h2's (only inside panels) font size bigger. Something like: .panel-body h2 {
font-size: 2.24 rem;
}
We can create a new branch to work on improving panel's title, even more, but I think it's out of the scope of this PR... which is mainly: adapt the reset_password page to new styles for consistency and improve it a bit (passwords match validation). From now on, at least design across |
f0073d9
to
0f170f0
Compare
@@ -539,7 +539,7 @@ label[required]::after{ | |||
} | |||
|
|||
.panel-body h2 { | |||
font-size: 1.9rem; | |||
font-size: 2.24rem; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ℹ️
font-size: 2.24rem; |
Pushed: bigger (font-size) h2's in panels, latest develop rebased and conflicts fixed. |
Good and fair enough |
…d devise views (registrations)
0f170f0
to
1a69128
Compare
Rebased (via merge) and deployed to staging. |
Works fine!! |
setCustomValidity
4.4.3
->4.5.0
) (changes)registrations
)ng-*
BEFORE

AFTER -> inline with other devise views
