Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

adapt reset password page to new styles #419

Merged
merged 2 commits into from
Oct 18, 2018
Merged

Conversation

markets
Copy link
Collaborator

@markets markets commented Sep 1, 2018

  • adapt reset password page to new styles for consistency + basic validation via setCustomValidity
  • upgrade devise (4.4.3 -> 4.5.0) (changes)
  • remove unused devise views (registrations)
  • remove old Angular annotations ng-*

BEFORE
captura de pantalla 2018-09-01 a la s 17 07 17

AFTER -> inline with other devise views
captura de pantalla 2018-09-01 a la s 17 06 53

Copy link
Collaborator

@sauloperez sauloperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find a bit odd, in terms of design, that cambiar mi contraseña looks smaller than the inputs' placeholders. IMO it should be at least the same size as its the header.

@markets
Copy link
Collaborator Author

markets commented Sep 4, 2018

I agree @sauloperez it could look much better 👌, I just followed the same markup as we currently use in the other devise views. This is:

<h2>Title</h2>

captura de pantalla 2018-09-04 a la s 22 57 06

The main difference with the rest (ie screenshot), is that in this case we don't have any sentence before the form. So, we can maybe make all panels h2, bigger? Should we also add a little explanation?

@sauloperez
Copy link
Collaborator

You mean increasing h2's font size or making this whole white box bigger?

@markets
Copy link
Collaborator Author

markets commented Sep 5, 2018

@sauloperez as a first approach or at least for this PR, I'd go with h2's (only inside panels) font size bigger.

Something like:

.panel-body h2 {
  font-size: 2.24 rem; 
}

2.24 rem as the inputs and buttons

We can create a new branch to work on improving panel's title, even more, but I think it's out of the scope of this PR... which is mainly: adapt the reset_password page to new styles for consistency and improve it a bit (passwords match validation).

From now on, at least design across devise related views will be "consistent" and this is better than the current inconsistency 😛 so, maybe we should move on with this h2 tweak, and probably someone with better design skills 😅 can review panel's title later?

@@ -539,7 +539,7 @@ label[required]::after{
}

.panel-body h2 {
font-size: 1.9rem;
font-size: 2.24rem;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️

@markets
Copy link
Collaborator Author

markets commented Sep 5, 2018

Pushed: bigger (font-size) h2's in panels, latest develop rebased and conflicts fixed.

@sauloperez
Copy link
Collaborator

Good and fair enough

@markets markets force-pushed the reset_pass_styles branch from 0f170f0 to 1a69128 Compare October 4, 2018 20:39
@enricostano
Copy link
Contributor

Rebased (via merge) and deployed to staging.

@sseerrggii
Copy link
Contributor

Works fine!!

@enricostano enricostano merged commit 8314b43 into develop Oct 18, 2018
@enricostano enricostano deleted the reset_pass_styles branch October 18, 2018 15:27
@enricostano enricostano mentioned this pull request Oct 19, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants