Return a default description when it is empty #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sauloperez
commented
Sep 27, 2018
| context 'integration' do | ||
| it 'creates as many PushNotification resources as needed' do | ||
| expect { creator.create! }.to change { PushNotification.count }.by(1) | ||
| end |
There was a problem hiding this comment.
testing only this was very naive IMO.
enricostano
approved these changes
Sep 27, 2018
mllocs
approved these changes
Oct 1, 2018
markets
approved these changes
Oct 7, 2018
|
Shall we invest some time in testing @sseerrggii ? |
|
Talked offline. We might have tested this already but we'll double check now that I deployed it to staging. |
|
Tested! ✔️ |
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the following error spotted in Sidekiq web UI. See below