Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Travis reads the .ruby-version file #443

Merged
merged 2 commits into from
Oct 18, 2018
Merged

Travis reads the .ruby-version file #443

merged 2 commits into from
Oct 18, 2018

Conversation

viktorsmari
Copy link
Contributor

@viktorsmari viktorsmari commented Oct 18, 2018 •
edited
Loading

No need to have it manually in the .travis.yml

If the ruby version is not specified by the rvm key, Travis CI uses the version specified in the .ruby-version file in the root of the repository if one is available.

@viktorsmari
Travis reads the .ruby-version file
3d17386 
No need to have it manually in the .travis.yml
@viktorsmari viktorsmari mentioned this pull request Oct 18, 2018
Closed
enricostano
enricostano suggested changes Oct 18, 2018
View reviewed changes
Copy link
Contributor

@enricostano enricostano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

.travis.yml Outdated
rvm:
- 2.3.0
#rvm:
#- 2.3.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind to just remove them completely instead of commenting the lines out? Thanks!

@viktorsmari
Copy link
Contributor Author

Done!

@enricostano enricostano merged commit 476e4e7 into coopdevs:develop Oct 18, 2018
@enricostano
Copy link
Contributor 

$ rvm use $(< .ruby-version) --install --binary --fuzzy
Required ruby-2.3.0 is not installed - installing.
...
$ ruby --version
ruby 2.3.0p0 (2015-12-25 revision 53290) [x86_64-linux]

Cool @viktorsmari 💪

@viktorsmari viktorsmari deleted the travis-uses-rbenv-file branch October 18, 2018 15:59
@enricostano enricostano mentioned this pull request Oct 19, 2018
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@enricostano enricostano enricostano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@viktorsmari @enricostano