fix: prepend subporject_subdir path for files in skip_in_exists #1896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: l.feng <43399351+msclock@users.noreply.github.com>
msclock
force-pushed
the
subproject_skip_if_exists
branch
from
25b8b16 to
42982c5
Compare
|
Thanks for your contribution, @msclock, and sorry for taking so long to respond. Could you add a test case that fails without the fix? |
I'll try later.🤔 |
|
@msclock Please feel free to reach out if you need help with the test case. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1894
Skip files in subproject subdir when run
git apply --reject --exclude.