Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

coqchk regression: "Fatal Error: User error: Inconsistent assumptions over module Coq.Init.Byte ." #11628

Closed
RalfJung opened this issue Feb 19, 2020 · 9 comments
Labels
needs: triage The validity of this issue needs to be checked, or the issue itself updated.

Comments

@RalfJung
Copy link
Contributor

Description of the problem

Yesterday, coqchk started failing on our CI. The commit where it started touches only docs, so this is most likely caused by a coqchk regression. You can see a failing log here.

Coq Version

Last version that worked:

name        coq
version     dev
source-hash fdcfe8b7
The Coq Proof Assistant, version 8.12+alpha (February 2020)
compiled on Feb 18 2020 8:27:53 with OCaml 4.07.1

First version that broke:

name        coq
version     dev
source-hash 43c3c7d6
The Coq Proof Assistant, version 8.12+alpha (February 2020)
compiled on Feb 18 2020 21:14:55 with OCaml 4.07.1

That corresponds to this commit range.

@SkySkimmer
Copy link
Contributor

We make validate in our CI job for Iris so this is quite strange.

@SkySkimmer
Copy link
Contributor

That corresponds to this commit range.

So #10204 #11529 #11530
I don't see how the other 2 could get this result so cc @ejgallego for #11529

@RalfJung
Copy link
Contributor Author

Indeed something is strange, this does not reproduce locally.

Maybe there is a problem with upgrading an existing Coq install in-place?

@RalfJung
Copy link
Contributor Author

Or maybe it is related to ocaml/opam#4091

@ejgallego
Copy link
Member

Maybe there is a problem with upgrading an existing Coq install in-place?

If you are not doing make clean then indeed bad things can happen. Proper incremental builds using make are not supported if the set of target files changes [they will be once we have Dune, but only between commits after the bootstrap]

@ejgallego ejgallego added the needs: triage The validity of this issue needs to be checked, or the issue itself updated. label Feb 19, 2020
@RalfJung
Copy link
Contributor Author

We are using opam, so we shouldn't have to manually clean anything.

@rjbou
Copy link

rjbou commented Feb 19, 2020

Some explanation in this ocaml/opam#4091 (comment)

@RalfJung
Copy link
Contributor Author

RalfJung commented Feb 19, 2020

@rjbou thanks!
So, could this lead to opam not removing old files when uninstalling/upgrading coq?

@RalfJung
Copy link
Contributor Author

Yeah looks like clearing the opam state made this issue go away. Sorry for the noise!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
needs: triage The validity of this issue needs to be checked, or the issue itself updated.
Projects
None yet
Development

No branches or pull requests

4 participants