Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Revert buggy commit mistakenly pushed with #11530 #11636

Merged
merged 1 commit into from
Feb 19, 2020
Merged

Revert buggy commit mistakenly pushed with #11530 #11636

merged 1 commit into from
Feb 19, 2020

Conversation

herbelin
Copy link
Member

This reverts commit 29919b7.

It was pushed by mistake as part of #11530. Sorry about it.

Possibly a cause for #11628 (??)

@herbelin
Revert "Granting coq#9516 and coq#9518 (support for numerals and stri…
25cab58 
…ngs in custom entries)."

This reverts commit 29919b7.

It was pushed by mistake as part of coq#11530. Sorry about it.
@herbelin herbelin requested review from a team as code owners February 19, 2020 20:11
@herbelin herbelin mentioned this pull request Feb 19, 2020
Merged
3 tasks
@ejgallego ejgallego self-assigned this Feb 19, 2020
@ejgallego ejgallego added the kind: fix This fixes a bug or incorrect documentation. label Feb 19, 2020
@ejgallego ejgallego added this to the 8.12+beta1 milestone Feb 19, 2020
ejgallego
ejgallego approved these changes Feb 19, 2020
View reviewed changes
Copy link
Member

@ejgallego ejgallego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this is a revert no further delay is needed.

@ejgallego ejgallego merged commit 25cab58 into coq:master Feb 19, 2020
ejgallego added a commit that referenced this pull request Feb 19, 2020
@ejgallego
Merge PR #11636: Revert buggy commit mistakenly pushed with #11530
a644482 
Reviewed-by: ejgallego
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ejgallego ejgallego ejgallego approved these changes

Assignees

@ejgallego ejgallego

Labels
kind: fix This fixes a bug or incorrect documentation.
Projects
None yet
Milestone
8.12+beta1
Development

Successfully merging this pull request may close these issues.
2 participants
@herbelin @ejgallego