Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Correcting the toolchain manager #580

Merged
merged 2 commits into from
Aug 21, 2023
Merged

Correcting the toolchain manager #580

merged 2 commits into from
Aug 21, 2023

Conversation

rtetley
Copy link
Collaborator

@rtetley rtetley commented Aug 21, 2023

Closes #566.

- We now use the server configuration provided by the toolchain manager
- By default, we will always use the vscoqtop path provided in user settings
- Otherwise we default to vscoqtop found in the PATH variable
- We search for coq std lib with vscoqtop -where
- All relevant eror messages and actions are sent to user
@rtetley rtetley marked this pull request as draft August 21, 2023 13:45
@rtetley rtetley requested a review from maximedenes August 21, 2023 13:55
@rtetley rtetley marked this pull request as ready for review August 21, 2023 13:55
@maximedenes
Copy link
Member

Maybe vscoq2 -> VsCoq in the messages? More future proof to not include the version number there, IMHO.

@rtetley rtetley merged commit 65f9890 into main Aug 21, 2023
@rtetley rtetley deleted the bug/vscoqtop-from-shell branch August 28, 2023 14:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use vscoqtop from shell path if not set in extension settings
2 participants