Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Ellipsis #834

Merged
merged 4 commits into from
Jul 19, 2024
Merged

Ellipsis #834

merged 4 commits into from
Jul 19, 2024

Conversation

rtetley
Copy link
Collaborator

@rtetley rtetley commented Jul 18, 2024

For larger goals, add an ellipsis mechanism. This leverages a depth parameter -> if depth of element > maxDepth then ellide.
On top of that, boxes now have an included collapse, or expand mechanism.
ellipsis

@rtetley
Copy link
Collaborator Author

rtetley commented Jul 18, 2024

ping @gares @ybertot

@ybertot
Copy link

ybertot commented Jul 18, 2024

How does it get triggered? If it is enough to click on a sub-expression to have it collapse/expand, I think this is too obtrusive. It should be an action that can be easily triggered, but not too easily.

@gares
Copy link
Member

gares commented Jul 18, 2024

Wow!

One thing to think about is what happens when the goal changes.

I agree about the clicking. I think we should come up with a list of actions (considering future work) and then decide what goes to a simple click and what requires a modifier or a dedicated contextual panel/menu.

I can recall a few ideas (from the past), but I'm sure there are more:

  • alternative display for a notation, eg a = b vs a =_nat b, or just a + b vs addn a b
  • about a symbol (like in the text buffer)
  • jump to def (as above)
  • apply tactic (eg. simpl or set) to the selected subterm

Anyway, hiding too-large terms and having a click on "..." expand a few levels more seems something that can be immediately useful. All the rest may need a bit more thinking.

@rtetley
Copy link
Collaborator Author

rtetley commented Jul 18, 2024

Just added a feature so that the hover effect (dashed line) and the click only work if you are pressing the 'Alt' key.

@rtetley rtetley merged commit c9cdb8b into main Jul 19, 2024
23 checks passed
@gares gares deleted the ellipsis branch July 19, 2024 15:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants