Fix tts_with_vc #3275
Merged
Fix tts_with_vc #3275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 041b4b6. Fixes coqui-ai#3143. The original issue (coqui-ai#3067) was people trying to use tts.tts_with_vc_to_file() with XTTS and was "fixed" in coqui-ai#3109. But XTTS has integrated VC and you can just do tts.tts_to_file(..., speaker_wav="..."), there is no point in passing it through FreeVC afterwards. So, reverting this commit because it breaks tts.tts_with_vc_to_file() for any model that doesn't have integrated VC, i.e. all models this method is meant for.
Fixes coqui-ai#1440. Passing a `speaker_wav` argument to regular Vits models failed because they don't support voice cloning. Now that argument is simply ignored.
|
Rerunning failes CI, looks like random quirks. If they pass, I merge. Thanks for the PR. |
|
@eginhard most of the models needs speaker_manager if they voice clone but I don't think it applies them all. We should probably attribute them in the model classes. |
|
CI seems happy now :)
Ok, I've peeled this to a new issue to keep track. I'm not familiar enough with all the models to take care of it now. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tts.tts_with_vc_to_file()with XTTS and was "fixed" in fix for issue 3067 #3109. But XTTS has integrated VC and you can just dotts.tts_to_file(..., speaker_wav="..."), there is no point in passing it through FreeVC afterwards. So, reverting this commit because it breakstts.tts_with_vc_to_file()for any model that doesn't have integrated VC, i.e. all models this method is meant for.tts_with_vc/tts_with_vc_to_file. This didn't work because they setspeaker=None. Now it's possible to pass a speaker ID.speaker_wavargument to regular Vits models failed because they don't support voice cloning. Now that argument is simply ignored if there is no speaker encoder (like in YourTTS).@erogol It would be useful to check in
tts_with_vc()whether the underlying model supports voice cloning directly and direct users totts_to_file(..., speaker_wav="...")in that case to avoid issues like in #3067. Is there some way to check this easily?