Fix typo 8xyE to 8xy6 #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test case was via
Open
Timendus
approved these changes
Jun 22, 2022
| @@ -156,15 +156,15 @@ v7 := 120 | |||
| v7 -= v6 | |||
| if v7 == 236 then i := imageok | |||
| sprite x2 y 4 | |||
| #test 8xy6 | |||
| #test 8xyE | |||
| y := 6 | |||
| drawop im8 im6 | |||
There was a problem hiding this comment.
Suggested change
| drawop im8 im6 | |
| drawop im8 imE |
| y := 6 | ||
| drawop im8 im6 | ||
| i := imagefalse | ||
| v6 := 224 | ||
| v6 <<= v6 | ||
| if v6 == 192 then i := imageok | ||
| sprite x2 y 4 | ||
| #test 8xyE | ||
| #test 8xy6 | ||
| y := 11 | ||
| drawop im8 imE |
There was a problem hiding this comment.
Suggested change
| drawop im8 imE | |
| drawop im8 im6 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You got the test case opposite.
8xy6: http://devernay.free.fr/hacks/chip8/C8TECH10.HTM#8xy6
8xyE http://devernay.free.fr/hacks/chip8/C8TECH10.HTM#8xyE\
I didn't know how to generate the .ch8 file, please generate new file for .ch8 too.
Love your test cases.