feat: adds action to update dependencies. #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
M4tteoP
reviewed
Apr 1, 2024
Comment on lines
+51
to
+52
| # deprecated. see https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ | ||
| #run: echo "::set-output name=changed::$(git status --porcelain | wc -l)" |
There was a problem hiding this comment.
Suggested change
| # deprecated. see https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ | |
| #run: echo "::set-output name=changed::$(git status --porcelain | wc -l)" |
Do we need to add this deprecated command and note on a newly created code?
| #run: echo "::set-output name=changed::$(git status --porcelain | wc -l)" | ||
| run: echo "changed=$(git status --porcelain | wc -l)" >> $GITHUB_OUTPUT | ||
|
|
||
| - uses: stefanzweifel/git-auto-commit-action@v5 |
There was a problem hiding this comment.
Am I missing something, or do you wish to skip opening a PR? If so, mixed feelings here, the import code should be okay, but even a self-approval while taking a quick look at the changes might be better than just pushing
There was a problem hiding this comment.
A legit question but what would that double check be? also, who performs it? I think what we could probably do is to make coraza parse the entire ruleset. Thoughts @anuraaga ?
fzipi
approved these changes
May 1, 2024
|
Why not just use renovatebot here? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an action to manually trigger the update of CRS or Coraza.