Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

audit: H should populate also with error logs. #1310

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

M4tteoP
Copy link
Member

@M4tteoP M4tteoP commented Feb 19, 2025

Part of #1305.
See #1305 (comment)

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 87.09677% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.78%. Comparing base (77fb22c) to head (1098a44).

Files with missing lines Patch % Lines
internal/auditlog/formats.go 60.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1310   +/-   ##
=======================================
  Coverage   81.77%   81.78%           
=======================================
  Files         170      170           
  Lines        9777     9803   +26     
=======================================
+ Hits         7995     8017   +22     
- Misses       1533     1536    +3     
- Partials      249      250    +1     
Flag Coverage Δ
coraza.rule.case_sensitive_args_keys 81.74% <87.09%> (+<0.01%) ⬆️
coraza.rule.multiphase_valuation 81.78% <87.09%> (+<0.01%) ⬆️
coraza.rule.no_regex_multiline 81.71% <87.09%> (+<0.01%) ⬆️
default 81.78% <87.09%> (+<0.01%) ⬆️
examples+ ?
examples+coraza.rule.case_sensitive_args_keys 81.74% <87.09%> (+<0.01%) ⬆️
examples+coraza.rule.multiphase_valuation 81.61% <87.09%> (+<0.01%) ⬆️
examples+coraza.rule.no_regex_multiline 81.63% <87.09%> (+<0.01%) ⬆️
examples+memoize_builders 81.73% <87.09%> (+<0.01%) ⬆️
examples+no_fs_access 81.06% <87.09%> (+<0.01%) ⬆️
ftw 81.78% <87.09%> (+<0.01%) ⬆️
memoize_builders 81.87% <87.09%> (+<0.01%) ⬆️
no_fs_access 81.23% <87.09%> (+<0.01%) ⬆️
tinygo 81.74% <87.09%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants