CORE-18638 Add permission for ingress controller to read IngressClass #5268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins build for PR 5268 build 3 Build Successful: |
davidcurrie
force-pushed
the
CORE-18638
branch
from
0c1c7fa to
35e64d0
Compare
|
|
Verified in https://ci02.dev.r3.com/job/Corda5/job/corda-simulations/job/release%2F5.2/50/ that the |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without permission to read cluster-scoped
IngressClassresources, the ingress-nginx controller processes updates to allIngressresources in the target namespace, regardless of whether or not they are associated with the ingress class it is configured with. (Reported in kubernetes/ingress-nginx#9662.) This results in the controller updating anyIngressresources defined for the REST API or P2P Gateway and consequent loss of connectivity until the rightful controller updates the resources again. The status flip-flops between the two controllers.This change gives the controller permission to view
IngressClassresources, which it does not really need (it uses the annotation-based approach to defining the ingress class) but causes it to check the ingress class name correctly.