Bump chartkick from 4.2.1 to 5.1.2 #2217
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2217 +/- ##
=======================================
Coverage 99.95% 99.95%
=======================================
Files 55 55
Lines 2125 2125
=======================================
Hits 2124 2124
Misses 1 1 ☔ View full report in Codecov by Sentry. |
|
@david-a-wheeler , for this one, I'm not sure offhand what visual tests we should do in the app to make sure nothing changed |
dependabot
bot
force-pushed
the
dependabot/bundler/chartkick-5.1.2
branch
from
488b6db to
3a948d5
Compare
|
@dependabot rebase |
Bumps [chartkick](https://github.com/ankane/chartkick) from 4.2.1 to 5.1.2. - [Changelog](https://github.com/ankane/chartkick/blob/master/CHANGELOG.md) - [Commits](ankane/chartkick@v4.2.1...v5.1.2) --- updated-dependencies: - dependency-name: chartkick dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/bundler/chartkick-5.1.2
branch
from
3a948d5 to
5dca5a4
Compare
|
We must do visual checks. Chartkick does weird stuff, and in fact, we can't use turbolinks appropriately because of its oddities. I'd like to eventually make chartkick load as "normal" JavaScript instead of being inline. |
|
@david-a-wheeler can you tell me how to get to the charts in the app? Maybe I'm missing something obvious but I don't see the charts. I know they're made by the project_stats_controller. Would I only see them for my own project? Can you give me some steps of what to check? Also, regarding the turbolinks, I think I might know how to fix that. I don't think it's necessary to move chartkick to the js version. |
Bumps chartkick from 4.2.1 to 5.1.2.
Changelog
Sourced from chartkick's changelog.
Commits
ba663f9Version bump to 5.1.2 [skip ci]2ad3a44Updated Chart.js to 4.4.6 [skip ci]a6abb37Updated changelog [skip ci]083ff2cVersion bump to 5.1.1 [skip ci]ad74021Updated Chart.js to 4.4.5 [skip ci]7dc6650Added check for assets config [skip ci]0f32158Only add assets to precompile list for Sprockets4a328e5Version bump to 5.1.0 [skip ci]aac53ceUpdated license year [skip ci]14ccbf1Updated license year [skip ci]Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)