removed auto-adding v to the etcd image version

[prune998]

When creating an etcdCluster resource, you provide an Image and a Version. Version` is a semver version depending on the EtcD image version you wish to use.

The default is to use Quay images, which are versioned using a pattern of v + semver, like v3.0.12.

So defining :

apiVersion: "etcd.database.coreos.com/v1beta2"
kind: "EtcdCluster"
metadata:
  name: "example-etcd-cluster"
spec:
  size: 3
  version: "3.1.10"
  repository: "quay.io/coreos/etcd"

Will create a Pod using image quay.io/coreos/etcd:v3.1.10.

This may be fine with Quay images, but when you are working with other Docker Registries, you may not want to add the v to the version.

The Operator should not force you to use a specific version pattern.

This PR removes the v addition to the version, allowing to use a real version name in the CRD.

[etcd-bot]

Can one of the admins verify this patch?

[etcd-bot]

Can one of the admins verify this patch?

[etcd-bot]

Can one of the admins verify this patch?

[prune998]

issue referenced in

• Version selection assumes etcd image versions will begin with "v" #1974
• Deploying a cluster with different repository/version fails on pull #1960

[alaypatel07]

I am wondering if instead of composing the image name using repository and version, it would be simpler to replace it with a key called image? The CR will look like:

apiVersion: "etcd.database.coreos.com/v1beta2"
kind: "EtcdCluster"
metadata:
  name: "example-etcd-cluster"
spec:
  size: 3
  image: "quay.io/coreos/etcd:v3.1.10"

[prune998]

Maybe doing this will make it harder to manage the upgrade process when only the image version is changed ?
That would also imply an API change, while this PR does not.

[alaypatel07]

I could be wrong, but I thought if we can compare the image instead of version here, the upgrade process can be handled.

Agreed, this would mean an API change, and I do not know if we would want it for simplicity or not.

[xmlking]

we also have issue with auto-adding v
our Pod Security Policy restrict images using with version number. we have to sign them and we have to use tag with digest something like this "sha256:4567464gfjfjfgjfjfjfjfjjfjfjfjfj354345534" if it adds "v" , then it breaks

[NormanFoxLee]

Is it possible to add digest: so we can use image@digest instead image:version?