40ignition-ostree: avoid jq try-catch #2797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There seems to be a bug in jq 1.7 where `try .foo catch "" | ascii_downcase` now fails. It seems like jq implements short-circuiting boolean operators, so we can rework this to instead just use a simpler `and` operator. Reported-by: Gursewak Mangat <gursmangat@gmail.com>
|
@gursewak1997 If you open an issue against jq, I can crosslink it here. |
dustymabe
approved these changes
Jan 12, 2024
gursewak1997
approved these changes
Jan 12, 2024
|
disabled auto-merge since there is a bump-lockfile job running right now. If this merges it will cause all of that work to be thrown away. Will merge after that finishes. |
|
Just a quick update: This was rather a issue in how in |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be a bug in jq 1.7 where
try .foo catch "" | ascii_downcasenow fails.It seems like jq implements short-circuiting boolean operators, so we can rework this to instead just use a simpler
andoperator.BZ issue: https://bugzilla.redhat.com/show_bug.cgi?id=2258285
Reported-by: Gursewak Mangat gursmangat@gmail.com