This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
fleetctl: reenable support for environment variables #1633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fleetctl has not been able to make use of environment variables such as FLEETCTL_ENDPOINT, because of a missing call to getFlagsFromEnv(). That was a regression from commit 848d356 ("fleetctl: convert cli to cobra"). Fix it by calling getFlagsFromEnv() again based on spf13/pflag instead of the native flag. Reported by @odolbeau. Fixes coreos#1631
|
awkward - nice catch! |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fleetctlhas not been able to make use of environment variables such asFLEETCTL_ENDPOINT, because of a missing call togetFlagsFromEnv(). That was a regression from commit 848d356("fleetctl: convert cli to cobra").Fix it by calling
getFlagsFromEnv()again based onspf13/pflaginstead of the native flag.Reported by @odolbeau.
Fixes #1631