Fix missing DisplayVersion registry key for nvm.iss

[awdr74100]

winget uses the DisplayVersion registry key to confirm whether the package should be updated:

winget will display the correct version:

this avoids the problem of constant updates caused by Unknown versions.

refer to this discussion.

[Mr1008]

This would be nice to have it merged and released so it is not constantly updated by winget

[github-actions]

This PR is stale because it has been open 45 days with no activity.

[SonnyRR]

Any update on this PR ? I'm still experiencing the issue with the unknown version both on Win 10 & Win 11 21H2 causing winget to always list that a new version is available.

[Mr1008]

@coreybutler Sorry for mentioning, would it be possible to include it in next release, please?

[balbertho]

I don't think this maybe the fix, since the DisplayVersion should be able to be set by Inno Setup in
https://github.com/jrsoftware/issrc/blob/bd96b87f5edc0317134e3d5c0b9ed321e3f01015/Projects/Install.pas#L692
Furthermore, the DisplayVersion is able to be set before 1.1.8 release.
What I found is that MyAppVersion is defined in

nvm-windows/nvm.iss

Line 4 in e050a10

#define MyAppVersion "1.1.9"

, but it has not been used in the same file, while older release like https://github.com/coreybutler/nvm-windows/blob/1.1.7/nvm.iss will use MyAppVersion in the same file, is it maybe just a typo issue?

[github-actions]

This PR is stale because it has been open 45 days with no activity.

[coreybutler]

lgtm

[balbertho]

@coreybutler really not a typo issue? 😂

[coreybutler]

@balbertho I merged because the separation of variables for the app ID was more consistent with the rest of the installer. The typo is an easy fix.

[balbertho]

@coreybutler oh, I am sorry, I just think that no need to write the custom registry when the installer do, not noticing the app id variables.