[Feature Request] Add batch_shape property to GP models #2301
Labels
Comments
|
@gpleiss any thoughts on this? |
|
Yeah this is a great idea! |
Balandat
added a commit
that referenced
this issue
Mar 19, 2023
Implements #2301. TODO: - support for approximate GP models - unit tests - verify compatibility with the botorch setup of other models
Balandat
added a commit
that referenced
this issue
May 21, 2023
Implements #2301. TODO: Verify compatibility with the botorch setup of other models
Balandat
added a commit
that referenced
this issue
Jun 4, 2023
Implements #2301. TODO: Verify compatibility with the botorch setup of other models
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
🚀 Feature Request
Expose a
batch_shapeproperty on models. For Exact GPs or models that have all the training inputs, this can just return the batch shape of the input tensors. For other models this can be overwritten as neededMotivation
See pytorch/botorch#1680 (comment) - for some fantasizing functionality we'd like to know what the batch shape of the model is to appropriately fantasize based on model outputs.
There are a lot of other use cases for such property, we currently have this defined on the botorch
Modelclass and are using it in a number of places (check the botorch repo).Pitch
Describe the solution you'd like
Upstream the functionality from botorch.
Describe alternatives you've considered
Not doing this. The downside is that it makes things rather cumbersome and requires some workarounds.
Are you willing to open a pull request? (We LOVE contributions!!!)
Sure
The text was updated successfully, but these errors were encountered: