Fix bug with PeriodicKernel.diag() #1919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Balandat
reviewed
Feb 18, 2022
- Refactor PerodicKernel + docs - Improve tests [Fixes #1915]
|
I'm wondering if we should also fix #1020 while we're at it - the lengthscale parameter is inconsistent with our other kernels (i.e. we should be squaring the lengthscale parameter). This would be a breaking change though... thoughts? Of course, we should save this for a different PR. |
|
@Balandat ready for a second review / merge. |
|
I have never really participated in PRs, so let me know if my comment is useful or not. I tried the PR on my code and it fixed the bug I described in pytorch/botorch#1112. |
Balandat
approved these changes
Apr 10, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Fixes #1915]
[Fixes #1926]