sign fix for gradient blocks #2598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@m-julian thanks for the PR! Would you be able to add a derivation of the gradient in the docstring of the kernel? |
|
@gpleiss I've added the equations for the gradient and Hessian blocks. I've also linked to the initial PR in the docstring that contains a pdf file with the full derivations. That pdf should be correct, I just messed up the signs in the initial implementation. I've also added the Matern52KernelGrad to the |
gpleiss
approved these changes
Jan 28, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sign of the first and second gradient blocks for the
Matern52KernelGradkernel was wrong. This PR should fix issue #2563. I've also updates the tests.