Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Unpin jaxtyping #2626

Merged
merged 1 commit into from
Jan 25, 2025
Merged

Unpin jaxtyping #2626

merged 1 commit into from
Jan 25, 2025

Conversation

saitcakmak
Copy link
Collaborator

The required jaxtyping version conflicts with the requirements of other libraries. The code appears to be compatible with newer versions, so attempting to unpin to see if anything breaks.

Copy link
Collaborator

@Balandat Balandat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, does the github CI actually test if the jaxtyping annotations work? IIUC this is for static typing and it doesn't seem from the workflow definitions that this is tested.

cc @gpleiss, @jacobrgardner

@saitcakmak
Copy link
Collaborator Author

@Balandat looks like the linear operator CI is supposed to be run with type checking (I didn't check the details of it) and passes (except for the docs, which are failing elsewhere as well). I don't know if there is anything else that specifically uses jaxtyping within GPyTorch (other than linear operators).

@Balandat
Copy link
Collaborator

cool lezdoit

@Balandat Balandat merged commit 4156bf4 into main Jan 25, 2025
7 checks passed
@Balandat Balandat deleted the jaxtyping branch January 25, 2025 02:31
@saitcakmak
Copy link
Collaborator Author

Figured out how to run jaxtyping. pytest --jaxtyping-packages=typeguard.typechecked only brings up one unrelated test failure.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants