Skip to content
This repository was archived by the owner on Jun 20, 2023. It is now read-only.

Task/14350 adapt new changes #4896

Merged

Conversation

naveeddotio
Copy link
Contributor

Description

Adapting new changes and refactoring thank you screen

Link to Jira

https://jira-ibs.wbs.net.sap/browse/EXPOSUREAPP-14350

@naveeddotio naveeddotio requested review from a team November 22, 2022 15:50
@naveeddotio naveeddotio self-assigned this Nov 22, 2022
@naveeddotio naveeddotio added the task part of a feature label Nov 22, 2022
@naveeddotio naveeddotio added this to the v3.0.0 milestone Nov 22, 2022
Copy link
Contributor

@flxschmidt flxschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@@ -114,7 +111,7 @@ struct SRSConsentViewModel {
ack1.addAttributes(attributes, range: NSRange(location: 0, length: AppStrings.SRSConsentScreen.legalBulletPoint01.count))

let ack2 = NSMutableAttributedString(string: "\(AppStrings.SRSConsentScreen.legalBulletPoint02)")
ack2.addAttributes(attributes, range: NSRange(location: 0, length: AppStrings.SRSConsentScreen.legalBulletPoint02.count))
ack2.addAttributes(attributes, range: NSRange(location: 52, length: 36))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nicer with a calculation, instead of static, but it's okay. Not so important. ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will add this to my todo list for later

// MARK: - Init

init(
viewModel: SRSDataProcessingInfoViewModel = .init()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like! 👍

Copy link
Contributor

@KathrinLuecke KathrinLuecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UA approved

@naveeddotio naveeddotio merged commit 210c234 into story/14171-support-sharing-self-test Nov 23, 2022
@naveeddotio naveeddotio deleted the task/14350-adapt-new-changes branch November 23, 2022 09:09
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
task part of a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants