This repository was archived by the owner on Jun 20, 2023. It is now read-only.
Task/14371 Developer Menu: SRS Options #4909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naveeddotio
reviewed
Dec 2, 2022
src/xcode/ENA/ENA/Source/Developer Menu/Helper/DMMenuItem.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Naveed Khalid <nkhalid.here@gmail.com>
naveeddotio
reviewed
Dec 2, 2022
| @@ -61,7 +61,7 @@ final class MockTestStore: Store, PPAnalyticsData { | |||
| var mostRecentRiskCalculationConfiguration: RiskCalculationConfiguration? | |||
| var forceAPITokenAuthorization = false | |||
| var recentTraceLocationCheckedInto: DMRecentTraceLocationCheckedInto? | |||
| var isSrsPrechecksEnabled = false | |||
| var dmIsSRSPreChecksEnabled = false | |||
There was a problem hiding this comment.
Don't know if this naming is consistent with our approach
There was a problem hiding this comment.
@30mar what do you think?
There was a problem hiding this comment.
I think isSrsPrechecksEnabled is fine as it was, we use flags for dev menus without adding the dm part.
There was a problem hiding this comment.
Good point, renamed it to isSrsPrechecksEnabled
naveeddotio
reviewed
Dec 2, 2022
| @@ -41,7 +56,7 @@ struct SRSConsentViewModel { | |||
| UIImage(imageLiteralResourceName: "SRS-Warn-Others-icon"), | |||
| text: .string(String( | |||
| format: AppStrings.SRSConsentScreen.instruction2, | |||
| "90" // to.do fetch the number from app config | |||
| String(timeBetweenSubmissionsInDays) | |||
naveeddotio
reviewed
Dec 5, 2022
src/xcode/ENA/ENA/Source/Developer Menu/DMSRSPrechecks/DMSRSOptionsViewModel.swift
Show resolved
Hide resolved
naveeddotio
approved these changes
Dec 5, 2022
30mar
approved these changes
Dec 5, 2022
puneetmahali1
approved these changes
Dec 6, 2022
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Link to Jira
https://jira-ibs.wbs.net.sap/browse/EXPOSUREAPP-14371
Screenshots