This repository was archived by the owner on Jun 20, 2023. It is now read-only.
Task/14355 add submission unit tests #4933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naveeddotio
suggested changes
Dec 14, 2022
| } | ||
| } | ||
|
|
||
| func testGIVEN_AuthorizeOTP_WHEN_NoNetworkConnection_THEN_NetworkErrorReturned() { |
There was a problem hiding this comment.
Can you please add a test case for .deviceBlocked?
There was a problem hiding this comment.
Please refer to this PR: https://github.com/corona-warn-app/cwa-app-ios/pull/4928/files
naveeddotio
suggested changes
Dec 14, 2022
| XCTFail("unexpected error case") | ||
| return | ||
| } | ||
| XCTAssertEqual(customError, .otherServerError) |
There was a problem hiding this comment.
Name of the test suggest that it should return internalServerError but in the end we are equating to otherServerError, both of them are different errors if we look into the enum types, am I missing something here?
naveeddotio
approved these changes
Dec 15, 2022
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add submission unit tests
Link to Jira
https://jira-ibs.wbs.net.sap/browse/EXPOSUREAPP-14355