This repository was archived by the owner on Jun 20, 2023. It is now read-only.
Fix/14578 no internet prevents clicking on srs #5019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So IIUC when you are not connected to the internet and click on the tile nothing happens. Like nothing at all? I don't think that's a good idea! Some sort of error should be shown to the user, otherwise this could lead to very confused users. |
|
@Ein-Tim This is under certain circumstances the situation with 3.0 and this PR will fix the issue. |
|
@thomasaugsten So there will actually be some sort of UI information presented to the user why this doesn't work? |
|
Depends if he never has an internet connection he will receive the error that we cannot check his phone time. |
30mar
approved these changes
Jan 25, 2023
30mar
reviewed
Jan 25, 2023
src/xcode/ENA/ENA/Source/Services/Risk/Provider/Helper/CachedAppConfiguration.swift
Show resolved
Hide resolved
30mar
suggested changes
Jan 25, 2023
30mar
approved these changes
Jan 25, 2023
naveeddotio
approved these changes
Jan 26, 2023
puneetmahali1
deleted the
fix/14578-not-internet-prevents-srs-clicking
branch
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
No internet connections prevents clicking on Self test submission
Link to Jira
https://jira-ibs.wbs.net.sap/browse/EXPOSUREAPP-14578
Screenshots
EXPOSUREAPP-14578.MP4